Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show a fun fact while pdf is loading #53

Merged
merged 3 commits into from
Jul 6, 2024
Merged

feat: show a fun fact while pdf is loading #53

merged 3 commits into from
Jul 6, 2024

Conversation

aamirazad
Copy link
Owner

@aamirazad aamirazad commented Jun 29, 2024 •
edited
Loading

TL;DR

Integrated a new feature in the Document Viewer that fetches and displays random advice from Advice Slip API.

What changed?

  1. Modified document-viewer.tsx to include a new state for storing advice fetched from the Advice Slip API.
  2. Added AdviceAPIType to the types directory.

Why?

I like websites that feel fun and developer made, not cooperate. Also, reading and thinking about advice makes the long loading much less painful.

@vercel Vercel
Copy link

vercel bot commented Jun 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
homelab-connector ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2024 5:16pm

This was referenced Jun 29, 2024
Merged
Merged
@aamirazad Graphite App
Copy link
Owner Author

aamirazad commented Jun 29, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @aamirazad and the rest of your teammates on Graphite Graphite

This was referenced Jun 29, 2024
Merged
Merged
Merged
Merged
@aamirazad aamirazad linked an issue Jun 30, 2024 that may be closed by this pull request
Add fun facts while things are loading #43
Closed
@aamirazad Graphite App
Copy link
Owner Author

Probably would be better to fetch advice on the server by putting it in actions.ts

@aamirazad aamirazad marked this pull request as ready for review July 6, 2024 17:03
@aamirazad Graphite App
Copy link
Owner Author

aamirazad commented Jul 6, 2024 •
edited
Loading

Merge activity

  • Jul 6, 1:12 PM EDT: @aamirazad started a stack merge that includes this pull request via Graphite.
  • Jul 6, 1:15 PM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 6, 1:17 PM EDT: @aamirazad merged this pull request with Graphite.

@aamirazad aamirazad force-pushed the 06-29-fix_only_download_the_pdf_once branch from 13062e8 to ab96e72 Compare July 6, 2024 17:12
Base automatically changed from 06-29-fix_only_download_the_pdf_once to main July 6, 2024 17:14
@aamirazad aamirazad force-pushed the 06-29-feat_show_a_fun_fact_while_pdf_is_loading branch from a4acb5a to 4c72edd Compare July 6, 2024 17:14
@aamirazad aamirazad merged commit 5845517 into main Jul 6, 2024
5 checks passed
@aamirazad aamirazad deleted the 06-29-feat_show_a_fun_fact_while_pdf_is_loading branch July 6, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add fun facts while things are loading
1 participant
@aamirazad